Support collectivites d'outremer #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avec codeDepartement='om' et latng basée sur ce qui s'est fait sur l'app android. cf https://github.com/CovidTrackerFr/vitemadose-android/blob/develop/app/src/main/java/com/cvtracker/vmd/data/OutreMerEntry.kt#L3
…in departements.json
fcamblor
changed the title
Luwangel
reviewed
May 19, 2021
src/views/vmd-home.view.ts
Outdated
| @@ -35,7 +35,15 @@ export class VmdHomeView extends LitElement { | |||
| } else { | |||
| const commune = event.detail.commune | |||
| const departements = await State.current.departementsDisponibles() | |||
| const departement = departements.find(({ code_departement }) => code_departement === commune.codeDepartement) | |||
| if(!departements.find(d => d.code_departement==='om')) { | |||
There was a problem hiding this comment.
It's not better to add this behavior in the State.current.departementsDisponibles() method?
There was a problem hiding this comment.
Oui, je suis d'accord
Après, ce qui serait encore mieux, c'est qu'on ait pas du tout à le faire :-D (eg, que le back le rajoute :) )
|
@fcamblor J'ai appliqué les petits changements que j'avais suggéré. Tout est bon pour moi. Si tu n'y vois pas d'inconvénient, on peut la valider :) |
|
Parfait merci @Luwangel :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #182
ommis à dispo par le back (cf Pas d'infos centres sur les collectivités d'outremer vitemadose#384)codeDepartement='om'