Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change timestamp to episode for logging #1325

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

theSquaredError
Copy link
Contributor

@theSquaredError theSquaredError commented Feb 10, 2023

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@qgallouedec
Copy link
Collaborator

Great @theSquaredError. Now you just need to update the changelog (docs/misc/changelog). Add a line after the line 47. You can also add your name to the list of contributors at the end of the changelog!

@theSquaredError
Copy link
Contributor Author

I have updated changelog

@qgallouedec
Copy link
Collaborator

Great, now let's see if the CI passes. In the meantime, can you check if there is a similar issue in the SB3-Contrib repository or in the RL-Zoo3 repository?

@theSquaredError
Copy link
Contributor Author

There is same issue in SB3-Contrib repository

@qgallouedec
Copy link
Collaborator

Thanks, could you also open a PR on sb3 contrib repo?

@qgallouedec qgallouedec merged commit 69b94dd into DLR-RM:master Feb 10, 2023
@qgallouedec
Copy link
Collaborator

Thanks for your (first) contribution @theSquaredError 🎉

@theSquaredError
Copy link
Contributor Author

Hi @qgallouedec , I have opened PR for sb3 contrib repo. Can you tell me some other issues which I can solve as the next thing and what to do to understand the library better?

@qgallouedec qgallouedec linked an issue Feb 11, 2023 that may be closed by this pull request
3 tasks
@qgallouedec
Copy link
Collaborator

qgallouedec commented Feb 13, 2023

Thank you for wanting to help improve the library. I recommend that you check out help wanted Help from contributors is welcomed issues. Also feel free to suggest improvements, like cleaning up the doc (some parameters lack description for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tensorboard logging not logging every log_interval timesteps
2 participants