Skip to content

Commit

Permalink
feat: remove feature flag(s) hiding the anvil explorer links (#3850)
Browse files Browse the repository at this point in the history
  • Loading branch information
Fran McDade authored and Fran McDade committed Feb 5, 2024
1 parent 6088502 commit bf9a9e5
Show file tree
Hide file tree
Showing 10 changed files with 190 additions and 324 deletions.
4 changes: 1 addition & 3 deletions explorer/app/shared/entities.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/**
* Set of possible feature flags.
*/
export enum FEATURES {
HEADER = "header",
}
export enum FEATURES {}
37 changes: 0 additions & 37 deletions explorer/app/shared/utils.ts

This file was deleted.

2 changes: 1 addition & 1 deletion explorer/next-sitemap.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const siteMapConfig = {
exclude: (process.env.SITEMAP_EXCLUDE ?? "").split(SEPARATOR),
generateIndexSitemap: false,
outDir: `./out${basePath}`,
siteUrl: `${process.env.NEXT_PUBLIC_SITEMAP_DOMAIN}${basePath}`,
siteUrl: `${process.env.NEXT_PUBLIC_SITEMAP_DOMAIN}${basePath}`, // TODO(cc) where is this being used? Should there be a slash between NEXT_PUBLIC_SITEMAP_DOMAIN and basePath?
};

export default siteMapConfig;
13 changes: 3 additions & 10 deletions explorer/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { Footer } from "@clevercanary/data-explorer-ui/lib/components/Layout/com
import { Header } from "@clevercanary/data-explorer-ui/lib/components/Layout/components/Header/header";
import { Main as DXMain } from "@clevercanary/data-explorer-ui/lib/components/Layout/components/Main/main";
import { setFeatureFlags } from "@clevercanary/data-explorer-ui/lib/hooks/useFeatureFlag/common/utils";
import { useFeatureFlag } from "@clevercanary/data-explorer-ui/lib/hooks/useFeatureFlag/useFeatureFlag";
import { AuthProvider } from "@clevercanary/data-explorer-ui/lib/providers/authentication";
import { ConfigProvider as DXConfigProvider } from "@clevercanary/data-explorer-ui/lib/providers/config";
import { ExploreStateProvider } from "@clevercanary/data-explorer-ui/lib/providers/exploreState";
Expand All @@ -25,9 +24,8 @@ import { config } from "app/config/config";
import { FEATURES } from "app/shared/entities";
import { NextPage } from "next";
import type { AppProps } from "next/app";
import { useEffect, useMemo } from "react";
import { useEffect } from "react";
import TagManager from "react-gtm-module";
import { configureHeader } from "../app/shared/utils";

const FEATURE_FLAGS = Object.values(FEATURES);
const SESSION_TIMEOUT = 15 * 60 * 1000; // 15 minutes
Expand All @@ -47,14 +45,9 @@ function MyApp({ Component, pageProps }: AppPropsWithComponent): JSX.Element {
const appConfig = config();
const { analytics, layout, redirectRootToPath, themeOptions } = appConfig;
const { gtmAuth, gtmId, gtmPreview } = analytics || {};
const { floating, footer } = layout || {};
const { floating, footer, header } = layout || {};
const theme = createAppTheme(themeOptions);
const { entityListType } = pageProps as AzulEntitiesStaticResponse;
const isFeatureFlag = useFeatureFlag(FEATURES.HEADER);
const configuredHeaderProps = useMemo(
() => configureHeader(appConfig, isFeatureFlag),
[appConfig, isFeatureFlag]
); // Configure header.
const Main = Component.Main || DXMain;

// Initialize Google Tag Manager.
Expand All @@ -74,7 +67,7 @@ function MyApp({ Component, pageProps }: AppPropsWithComponent): JSX.Element {
<AuthProvider sessionTimeout={SESSION_TIMEOUT}>
<LayoutStateProvider>
<AppLayout>
<Header {...configuredHeaderProps} />
<Header {...header} />
<ExploreStateProvider entityListType={entityListType}>
<FileManifestStateProvider>
<Main>
Expand Down
2 changes: 1 addition & 1 deletion explorer/site-config/anvil-catalog/dev/.env
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
NEXT_PUBLIC_SITE_CONFIG='anvil-catalog-dev'
NEXT_PUBLIC_SITEMAP_DOMAIN='https://anvilproject.dev.clevercanary.com/'
NEXT_PUBLIC_SITEMAP_DOMAIN='https://anvilproject.dev.clevercanary.com'
NEXT_PUBLIC_BASE_PATH='/data'
SITEMAP_EXCLUDE='/export*,/login'
Loading

0 comments on commit bf9a9e5

Please sign in to comment.