Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnVIL Explorer] Organize left hand filters by named categories #4046

Closed
NoopDog opened this issue May 22, 2024 · 0 comments · Fixed by #4067
Closed

[AnVIL Explorer] Organize left hand filters by named categories #4046

NoopDog opened this issue May 22, 2024 · 0 comments · Fixed by #4067
Assignees
Labels
canary Done by the Clever Canary team

Comments

@NoopDog
Copy link
Collaborator

NoopDog commented May 22, 2024

Need

To make it easier to understand what filters are available it can be helpful to group them but the entity the apply to. For example, on the HCA Site the filters on the left have been categorized to look like this:

image

Whereas on AnVIL the current filters look like this:

image

Approach

Group the filters into named categories as defined below on AnVIL Explorer

  • Dataset

    • Dataset Name
    • Dataset Identifier
    • Consent Group
  • Donor

    • Diagnosis
    • Organism Type
    • Reported Ethnicity
    • Phenotypic Sex
  • Biosample

    • Anatomical Site
    • BioSample Type
  • File

    • file format

    This is configured in the categoryGroupConfig object in config.ts for each site. For example the HCA site is configured here:

The corresponding file for AnVIL CMG is here:

Definition of Done

  1. The AnVIL Explorer is updated to use the new groupings for filters defined above.
  2. The E2E ( Playwright Tests) for AnVIL Explorer are updated to pass if required.
@github-actions github-actions bot added the canary Done by the Clever Canary team label May 22, 2024
@jpaten jpaten linked a pull request Jul 5, 2024 that will close this issue
frano-m pushed a commit that referenced this issue Jul 8, 2024
* feat: added filter categories to anvil-cmg (#4046)

* feat: added filter category for data modality (#4046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants