Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump modules minimal Go version to 1.22 #28452

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Aug 14, 2024

What does this PR do?

Now that the OpenTelemetry project has bumped their minimal version to 1.22, do the same.
open-telemetry/opentelemetry-collector-contrib#34658

Motivation

Stay up to date, and fix failing version compatibility test #incident-29728.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/no-code-change Skip QA week as there is no code change in Agent code labels Aug 14, 2024
@pgimalac pgimalac requested review from a team as code owners August 14, 2024 08:17
@pgimalac pgimalac requested a review from mx-psi August 14, 2024 08:17
Copy link
Member

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for container-platform files

@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024

Regression Detector

Regression Detector Results

Run ID: 25d186eb-6096-4afa-bf22-c935f0918b10 Metrics dashboard Target profiles

Baseline: fe13dea
Comparison: 247b97f

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
otel_to_otel_logs ingress throughput +1.08 [+0.27, +1.90] Logs
tcp_syslog_to_blackhole ingress throughput +1.04 [-11.87, +13.96] Logs
pycheck_1000_100byte_tags % cpu utilization +0.77 [-4.11, +5.66] Logs
idle memory utilization +0.33 [+0.30, +0.36] Logs
basic_py_check % cpu utilization +0.20 [-2.48, +2.88] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
file_tree memory utilization -0.42 [-0.49, -0.35] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.62 [-1.52, +0.27] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@KSerrania
Copy link
Contributor

Force-merging the PR to fix main.

@KSerrania KSerrania merged commit 782ccb5 into main Aug 14, 2024
265 checks passed
@KSerrania KSerrania deleted the pgimalac/bump-minimal-go-version-1-22 branch August 14, 2024 11:40
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.56.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.56.x 7.56.x
# Navigate to the new working tree
cd .worktrees/backport-7.56.x
# Create a new branch
git switch --create backport-28452-to-7.56.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 782ccb5f4e427cbbfb152e9c082c6d33d6e14b88
# Push it to GitHub
git push --set-upstream origin backport-28452-to-7.56.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.56.x

Then, create a pull request where the base branch is 7.56.x and the compare/head branch is backport-28452-to-7.56.x.

agent-platform-auto-pr bot pushed a commit that referenced this pull request Aug 14, 2024
Now that the OpenTelemetry project has bumped their minimal version to 1.22, do the same.
open-telemetry/opentelemetry-collector-contrib#34658

Stay up to date, and fix failing version compatibility test #incident-29728.

(cherry picked from commit 782ccb5)
Copy link
Contributor

@wiyu wiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from processes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.