Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to code style #3322

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Adhere to code style #3322

merged 1 commit into from
Mar 19, 2019

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Fix style for apache integration according to #3299

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@ChristineTChen ChristineTChen requested a review from a team as a code owner March 18, 2019 18:29
@ofek ofek changed the title Fix style for apache Adhere to code style Mar 19, 2019
ofek
ofek approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek ofek merged commit 99f5120 into master Mar 19, 2019
@ofek ofek deleted the christine/format-apache branch March 19, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/apache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristineTChen @ofek