Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch2 test for new user type versioning. #5

Merged
merged 7 commits into from
Feb 24, 2021
Merged

Conversation

mpb27
Copy link
Contributor

@mpb27 mpb27 commented Feb 24, 2021

Took the original user type versioning test and updated it to Catch2. Also added vector tests.

The tests indicate that you can increase or decrease the size of the char array in the struct without any issues.

Also when loading V2 struct from V1 data - the struct maintains the default values specified for any not serialized members. :-)

Next, I'd like to test matrices of custom structs. And performance.

@DavidAce DavidAce linked an issue Feb 24, 2021 that may be closed by this pull request
@DavidAce
Copy link
Owner

Awesome! Very nice unit test. Good idea to check the different layouts as well.
I made a symbolic change removing the <iostream> header just to get see how this all works. This should be good to merge when the checks finish.

@DavidAce DavidAce merged commit 86429a2 into DavidAce:dev Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add readDataset() overload that takes hid::h5t.
2 participants