[three] r169 #70684
Merged
[three] r169 #70684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Methuselah96 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70684,
"author": "Methuselah96",
"headCommitOid": "28392176b981d57dea464fe3c065dc9b7fe78156",
"mergeBaseOid": "9a84bea2f43a3c4eda364acc196cb5b6773238dd",
"lastPushDate": "2024-09-26T15:53:51.000Z",
"lastActivityDate": "2024-09-26T16:55:41.000Z",
"mergeOfferDate": "2024-09-26T16:50:31.000Z",
"mergeRequestDate": "2024-09-26T16:55:41.000Z",
"mergeRequestUser": "Methuselah96",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "three",
"kind": "edit",
"files": [
{
"path": "types/three/build/three.webgpu.nodes.d.ts",
"kind": "definition"
},
{
"path": "types/three/build/three.webgpu.nodes.min.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/Addons.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/controls/DragControls.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/controls/TransformControls.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/exporters/EXRExporter.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/exporters/KTX2Exporter.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/geometries/SDFGeometryGenerator.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/helpers/LightProbeHelper.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/helpers/LightProbeHelperGPU.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/lights/LightProbeGenerator.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/lines/Line2.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/lines/LineGeometry.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/lines/LineMaterial.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/lines/LineSegments2.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/lines/LineSegmentsGeometry.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/loaders/DRACOLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/loaders/TiltLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/modifiers/CurveModifier.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/modifiers/CurveModifierGPU.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/objects/Lensflare.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/objects/LensflareMesh.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/GPUStatsPanel.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/GeometryCompressionUtils.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/PackedPhongMaterial.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/ShadowMapViewer.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/ShadowMapViewerGPU.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/SkeletonUtils.d.ts",
"kind": "definition"
},
{
"path": "types/three/examples/jsm/utils/TextureUtilsGPU.d.ts",
"kind": "definition"
},
{
"path": "types/three/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/three/src/Three.WebGPU.Nodes.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/Three.WebGPU.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/audio/Audio.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/core/BufferAttribute.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/core/InterleavedBuffer.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/core/Object3D.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/core/Raycaster.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/extras/Controls.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/loaders/MaterialLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/loaders/nodes/NodeLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/loaders/nodes/NodeMaterialLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/loaders/nodes/NodeObjectLoader.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/materials/nodes/NodeMaterial.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/materials/nodes/manager/NodeMaterialObserver.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/math/Quaternion.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/math/Triangle.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/Nodes.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/TSL.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/accessors/BufferAttributeNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/accessors/MaterialNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/accessors/ModelNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/accessors/Normal.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/accessors/Object3DNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/accessors/VelocityNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/core/Node.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/core/NodeUtils.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/core/StructTypeNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/core/UniformNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/display/ColorSpaceFunctions.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/display/ColorSpaceNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/display/ScreenNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/display/ToneMappingFunctions.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/display/ToonOutlinePassNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/display/ViewportNode.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/nodes/functions/material/getShIrradianceAt.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/objects/BatchedMesh.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/objects/Group.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/objects/LOD.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/WebGLRenderer.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/BundleGroup.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/ClippingContext.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/RenderBundles.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/RenderContext.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/RenderList.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/RenderObject.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/Renderer.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/StandardRenderer.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/nodes/NodeBuilderState.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/common/nodes/Nodes.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/webgl/WebGLCapabilities.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/webgl/WebGLPrograms.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/webgpu/WebGPURenderer.Nodes.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/webgpu/WebGPURenderer.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/webgpu/nodes/BasicNodeLibrary.d.ts",
"kind": "definition"
},
{
"path": "types/three/src/renderers/webgpu/nodes/StandardNodeLibrary.d.ts",
"kind": "definition"
}
],
"owners": [
"joshuaellis",
"Methuselah96"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-09-26T16:49:54.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2377354557,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
Hey @Methuselah96, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @joshuaellis — please review this PR in the next few days. Be sure to explicitly select |
44 tasks
jakebailey
approved these changes
Sep 26, 2024
typescript-bot
added
Maintainer Approved
Self Merge
|
@Methuselah96: Everything looks good here. I am ready to merge this PR (at 2839217) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@joshuaellis: you can do this too.) |
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.If changing an existing definition:
package.json.