Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic API key generation for teams. Fixes part of issue #2552. #3574

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/_docs/integrations/rest-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ FireFox extensions can be use to quickly use the Swagger UI Console.

![Swagger UI Console](/images/screenshots/swagger-ui-console.png)

Prior to using the REST APIs, an API Key must be generated. By default, creating a team will also create a corresponding
API key. A team may have multiple keys.
Prior to using the REST APIs, an API Key must be generated. By default, creating a team will NOT create a an API key. A team may have multiple keys.

![Teams - API Key](/images/screenshots/teams.png)
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public Response createTeam(Team jsonTeam) {
);

try (QueryManager qm = new QueryManager()) {
final Team team = qm.createTeam(jsonTeam.getName(), true);
final Team team = qm.createTeam(jsonTeam.getName(), false);
super.logSecurityEvent(LOGGER, SecurityMarkers.SECURITY_AUDIT, "Team created: " + team.getName());
return Response.status(Response.Status.CREATED).entity(team).build();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ public void createTeamTest() {
Assert.assertNotNull(json);
Assert.assertEquals("My Team", json.getString("name"));
Assert.assertTrue(UuidUtil.isValidUUID(json.getString("uuid")));
Assert.assertTrue(json.getJsonArray("apiKeys").isEmpty());
}

@Test
Expand Down