Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag support for notifications, and REST endpoints for tagging & untagging notifications in bulk #4031

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Aug 3, 2024

Description

Adds the ability to assign tags to notification rules ("Alerts" in the frontend).

This provides a more convenient way to limit notifications to only a subset of projects. Previously, projects had to be selected individually, which of course doesn't scale.

Further, this change extends the functionality introduced in #3924 and #3896 to now also cover notification tags.

Addressed Issue

Closes #2975
Supersedes #3506

Additional Details

Frontend PR: DependencyTrack/frontend#980

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Aug 3, 2024
@nscuro nscuro added this to the 4.12 milestone Aug 3, 2024
@nscuro nscuro force-pushed the notification-tags branch 3 times, most recently from 0e5ee46 to 5150994 Compare August 31, 2024 16:35
@nscuro nscuro marked this pull request as ready for review August 31, 2024 16:51
Copy link

codacy-production bot commented Aug 31, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 88.36% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7ce8e04) 22251 17080 76.76%
Head commit (68e615a) 22419 (+168) 17229 (+149) 76.85% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4031) 275 243 88.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Supersedes DependencyTrack#3506

Co-authored-by: Sebastien Delcoigne <sebastien.delcoigne@gmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro merged commit a351758 into DependencyTrack:master Aug 31, 2024
11 checks passed
@nscuro nscuro deleted the notification-tags branch August 31, 2024 21:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Limits to Tags" for Alerts
1 participant