Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump python version to >=3.6 #660

Merged
merged 2 commits into from
Oct 25, 2022
Merged

bump python version to >=3.6 #660

merged 2 commits into from
Oct 25, 2022

Conversation

igorbrigadir
Copy link
Contributor

@igorbrigadir igorbrigadir commented Oct 20, 2022 •
edited
Loading

fix #659: humanize requires >=3.6 so previous versions would have been broken anyway, and we test against 3.8, and i ran it in 3.7 so that for sure works too.

@igorbrigadir
bump python version to >=3.6
6721df0 
humanize requires >=3.6 so previous versions would have been broken anyway
edsu
edsu approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@edsu edsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @igorbrigadir !

@igorbrigadir igorbrigadir merged commit a29b45a into main Oct 25, 2022
@igorbrigadir igorbrigadir deleted the require-py36 branch October 25, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsu edsu edsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“python_requires” should be set with “>=3.6”, but twarc 2.12.0 set as ">=3.3".
2 participants
@igorbrigadir @edsu