voter fixes

DocPlanner · Apr 29, 2014 · 2069794 · 2069794
1 parent b214121
commit 2069794
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/DependencyInjection/Compiler/GateKeeperCompilerPass.php b/DependencyInjection/Compiler/GateKeeperCompilerPass.php
@@ -27,6 +27,9 @@ public function process(ContainerBuilder $container)
 			return;
 		}
 
+		$definition = $container->getDefinition('gatekeeper.voter');
+		$definition->addArgument(new Reference($container->getParameter('gatekeeper.provider.service')));
+
 		$definition = $container->getDefinition('gatekeeper');
 		$definition->addArgument(new Reference($container->getParameter('gatekeeper.repository.service')));
 

diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -24,6 +24,9 @@ public function getConfigTreeBuilder()
 				->scalarNode('repository_service')
 					->defaultValue('gatekeeper.repository.dummy')
 				->end()
+			->scalarNode('provider_service')
+					->defaultValue('gatekeeper.gates_provider.dummy')
+				->end()
 			->end();
 
         return $treeBuilder;

diff --git a/DependencyInjection/GateKeeperExtension.php b/DependencyInjection/GateKeeperExtension.php
@@ -23,6 +23,7 @@ public function load(array $configs, ContainerBuilder $container)
         $config = $this->processConfiguration($configuration, $configs);
 
 		$container->setParameter('gatekeeper.repository.service', $config['repository_service']);
+		$container->setParameter('gatekeeper.provider.service', $config['provider_service']);
 
 		$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
 		$loader->load('services.yml');

diff --git a/Resources/config/services.yml b/Resources/config/services.yml
@@ -15,7 +15,7 @@ services:
 
     gatekeeper.voter:
         class: GateKeeperBundle\Voter\GateKeeper
-        arguments: [@gatekeeper, @gatekeeper.gates_provider.dummy]
+        arguments: [@gatekeeper]
         tags:
           - { name: security.voter }
 

diff --git a/Voter/GateKeeper.php b/Voter/GateKeeper.php
@@ -48,12 +48,7 @@ public function __construct(Keeper $gateKeeper, GatesProviderInterface $gatesPro
 	 */
 	public function supportsAttribute($attribute)
 	{
-		if (null === $this->gates)
-		{
-			$this->gates = $this->gatesProvider->getGates();
-		}
-
-		return in_array($attribute, $this->gates);
+		return strpos($attribute, 'GATE_') === 0;
 	}
 
 	/**
@@ -92,7 +87,7 @@ public function vote(TokenInterface $token, $object, array $attributes)
 		}
 
 		$user = $token->getUser() instanceof ObjectInterface ? $token->getUser() : null;
-		$attributes = is_array($object) ? $object : [];
+		$object = is_array($object) ? $object : [];
 
 		if ($this->gateKeeper->hasAccess($attributes[0], $user, $object))
 		{