Make validate return more clear

ENCODE-DCC · Aug 1, 2020 · fc8a470 · fc8a470
1 parent 221d36b
commit fc8a470
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/encoded/reports/metadata.py b/src/encoded/reports/metadata.py
@@ -223,6 +223,7 @@ def _validate_request(self):
         type_params = self.param_list.get('type', [])
         if len(type_params) != 1:
             raise HTTPBadRequest(explanation='URL requires one "type" parameter.')
+        return True
 
     def _initialize_report(self):
         self._build_header()

diff --git a/src/encoded/tests/test_metadata.py b/src/encoded/tests/test_metadata.py
@@ -945,7 +945,7 @@ def test_metadata_metadata_report_validate_request(dummy_request):
         '&files.status!=archived&files.biological_replicates=2'
     )
     mr = MetadataReport(dummy_request)
-    assert mr._validate_request() is None
+    assert mr._validate_request()
     dummy_request.environ['QUERY_STRING'] = (
         'type=Experiment&type=Annotation&files.file_type=bigWig&files.file_type=bam'
         '&files.replicate.library.size_range=50-100'