ENCD-5432 Use WalkMe test snippet on nonproduction hosts #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldello
approved these changes
Jul 27, 2020
| @@ -46,7 +46,7 @@ export default class Navigation extends React.Component { | |||
| /** ID of the currently dropped-down main navigation menu; '' if none */ | |||
| openDropdown: '', | |||
| /** True if test warning banner visible; default depends on domain */ | |||
| testWarning: !productionHost[url.parse(context.location_href).hostname], | |||
| testWarning: !isProductionHost(context.location_href), | |||
There was a problem hiding this comment.
This is easier to understand.
| * @return True if code runs on production host | ||
| */ | ||
| export const isProductionHost = currentUrl => ( | ||
| ['www.encodeproject.org', 'encodeproject.org', 'www.encodedcc.org'].includes(url.parse(currentUrl).hostname) |
There was a problem hiding this comment.
Something in the back of my head is telling me this can be done with regex much better. Anyway, this is good as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.