ENCD-5537 save browser position on sort #3555
Conversation
| let x0 = this.state.x0; | ||
| let x1 = this.state.x1; | ||
| if (this.chartdisplay) { | ||
| const scrollLocation = this.chartdisplay.getElementsByClassName('hpgv_panel-header')[0].getElementsByTagName('span')[0].innerText; |
There was a problem hiding this comment.
The older means of referencing DOM like using "getElementsByClassName" is done when you need I speed. The speed difference is negligible unless you are using it in a loop with tens of thousands of iterations. Is there a special reason you are using it?
There was a problem hiding this comment.
Do you mean that it would be better to use a ref? I think that could be tricky since I'm referring to an element generated in a component in a library. I thought about making a method to return the browser position but this was the simplest solution since it didn't require any changes to Valis and I think it should work consistently.
| @@ -522,7 +522,22 @@ class GenomeBrowser extends React.Component { | |||
| if (files.length > 0) { | |||
| tracks = this.filesToTracks(newFiles, this.props.label, domain); | |||
There was a problem hiding this comment.
I take it that this PR is part of an addition to a different ticket...?
There was a problem hiding this comment.
No, this is the only change.
Currently when you click on the sort buttons on the Valis browser, the position is reset to the default position. If the user has scrolled the browser to a new location, we want the browser to preserve this new location when the sort buttons are clicked.