Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named indices for n-rank arrays #400

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Use named indices for n-rank arrays #400

merged 6 commits into from
Sep 13, 2022

Conversation

matt-frey
Copy link
Member

Closes #251.

@matt-frey matt-frey added enhancement / optimisation Improve algorithm or behaviour 3D Issues and pull requests related to the 3D version labels Aug 29, 2022
@matt-frey matt-frey self-assigned this Aug 29, 2022
sjboeing
sjboeing reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@sjboeing sjboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the code clearer indeed! I had a look at this and caught 2 small possible issues. Otherwise, probably best to see if results still reproduce.

@matt-frey matt-frey merged commit a04cfe5 into main Sep 13, 2022
@matt-frey matt-frey deleted the array-index branch September 13, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjboeing sjboeing sjboeing left review comments

Assignees

@matt-frey matt-frey

Labels
3D Issues and pull requests related to the 3D version enhancement / optimisation Improve algorithm or behaviour
Projects
None yet
Milestone
Implementation of the serial 3D model
Development

Successfully merging this pull request may close these issues.

Use named indices for n-rank arrays
2 participants
@matt-frey @sjboeing