Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply nearest fix in 2d #403

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Apply nearest fix in 2d #403

merged 2 commits into from
Sep 27, 2022

Conversation

matt-frey
Copy link
Member

This does the same fix in 2D as in 3D. However, we did not experience any issues in 2D.

@matt-frey matt-frey added the 2D Issues and pull requests related to the 2D version label Sep 13, 2022
@matt-frey matt-frey self-assigned this Sep 13, 2022
sjboeing
sjboeing approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@sjboeing sjboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support bringing these changes in. Looks good to me!

@matt-frey matt-frey merged commit fbf15fd into main Sep 27, 2022
@matt-frey matt-frey deleted the 2d-nearest-fix branch September 27, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjboeing sjboeing sjboeing approved these changes

@daviddritschel daviddritschel Awaiting requested review from daviddritschel

Assignees

@matt-frey matt-frey

Labels
2D Issues and pull requests related to the 2D version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-frey @sjboeing