Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to moist setup: shorter run, smooth edge bubble #414

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Conversation

sjboeing
Copy link
Collaborator

@matt-frey: replacing the moist setup with a smooth bubble. Limiting to 1000 seconds.

@sjboeing sjboeing marked this pull request as ready for review November 11, 2022 13:23
@sjboeing
Copy link
Collaborator Author

@matt-frey: I will start to slowly bring in my changes.

@matt-frey matt-frey added enhancement / optimisation Improve algorithm or behaviour 3D Issues and pull requests related to the 3D version labels Nov 11, 2022
Copy link
Member

@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see this looks okay.

examples/write_moist_setup.py Show resolved Hide resolved
@sjboeing sjboeing merged commit 0d15c2b into main Nov 11, 2022
@sjboeing sjboeing deleted the smooth_bubble branch November 11, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D Issues and pull requests related to the 3D version enhancement / optimisation Improve algorithm or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants