Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boundary surface fluxes #451

Merged
merged 38 commits into from
Sep 20, 2023
Merged

Add boundary surface fluxes #451

merged 38 commits into from
Sep 20, 2023

Conversation

matt-frey
Copy link
Member

@matt-frey matt-frey commented Apr 14, 2023 •
edited
Loading

Add boundary surface fluxes for buoyancy and humidity as in MPIC.

@matt-frey matt-frey added feature request New feature or request 3D Issues and pull requests related to the 3D version labels Apr 14, 2023
@matt-frey matt-frey self-assigned this Apr 14, 2023
sjboeing
sjboeing reviewed Apr 14, 2023
View reviewed changes
src/3d/fields/fields.f90 Outdated Show resolved Hide resolved
@matt-frey matt-frey added this to the 0.14.0 milestone May 7, 2023
@matt-frey matt-frey changed the base branch from main to 3d-mpi-model May 10, 2023 09:51
@matt-frey
Merge branch '3d-mpi-model' of github.com:EPIC-model/epic into bndry-…
9fa767a 
…surface-fluxes
@matt-frey
make bilinear routine public
19c1b69
@matt-frey
in parallel version periodic_index_shift not needed
8991d85
@matt-frey
use mpi_stop; make mpi-tests compile
084fcd1
@matt-frey
distinguish between scalar and vector fields in field_mpi; enable 2d …
affe984 
…fields
@matt-frey
bndry_fluxes_fill_halo
bbce308
@matt-frey
use number of dimensions to allocate buffers
bac7552
@matt-frey
fix typo in preprocessor directive
33f645f
@matt-frey
add missing mpi_stop; fix module routine include
dc4c18b
@matt-frey
fix array dimensions
7d30789
@matt-frey
allocate and deallocate boundary fluxes
addc0f7
@matt-frey
Merge branch '3d-mpi-model' of github.com:EPIC-model/epic into bndry-…
acc68a0 
…surface-fluxes
@matt-frey
Merge branch '3d-mpi-model' of github.com:EPIC-model/epic into bndry-…
292f14e 
…surface-fluxes
@matt-frey
fix units; change factor to have only units of time
fb0913d
@matt-frey
fix typo
4ba951a
@matt-frey
add boundary flux timer
bdf953d
@matt-frey matt-frey changed the base branch from 3d-mpi-model to dev-0.14.0 May 13, 2023 13:14
@matt-frey matt-frey marked this pull request as ready for review June 3, 2023 08:42
@matt-frey matt-frey mentioned this pull request Jun 6, 2023
Open
sjboeing
sjboeing reviewed Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@sjboeing sjboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The one thing that would/will take me some more time is to carefully check the halo indices, though maybe the unit tests largely take care of this.

@matt-frey
Copy link
Member Author

Which halo indices?

@matt-frey matt-frey removed the request for review from daviddritschel June 17, 2023 10:09
@sjboeing
Copy link
Collaborator

Which halo indices?

The ones in field_mpi. I realise you probably just copied them from the 3D fields though let me know if you would like me to double-check.

@matt-frey
Copy link
Member Author

Yes, I copied the 3D ones and removed the vertical direction.

sjboeing
sjboeing approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@sjboeing sjboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Matthias. Let me know if there is anything specific that I should look into. Are there any tests that would be worth putting in with surface fluxes (e.g. conservation)?

@matt-frey
Copy link
Member Author

Do you think of unit tests? You might have a look at the time step estimate. I put in a estimate to ensure that initial time steps include the boundary fluxes.

@matt-frey matt-frey merged commit ffd82a4 into dev-0.14.0 Sep 20, 2023
@matt-frey matt-frey deleted the bndry-surface-fluxes branch September 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjboeing sjboeing sjboeing approved these changes

Assignees

@matt-frey matt-frey

Labels
3D Issues and pull requests related to the 3D version feature request New feature or request
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-frey @sjboeing