Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request-based RMA #472

Merged
merged 11 commits into from
May 17, 2023
Merged

Use request-based RMA #472

merged 11 commits into from
May 17, 2023

Conversation

matt-frey
Copy link
Member

Instead of MPI_Get/MPI_Put we use MPI_RGet/MPI_RPut. A MPI_R*` routine allocates a communication request object that can be use to wait for completion. See for example https://www.open-mpi.org/doc/v4.1/man3/MPI_Rget.3.php

@matt-frey matt-frey added 3D Issues and pull requests related to the 3D version MPI MPI related issues and pull requests labels May 7, 2023
@matt-frey matt-frey added this to the 0.13.0 milestone May 7, 2023
@matt-frey matt-frey self-assigned this May 7, 2023
@matt-frey matt-frey added the enhancement / optimisation Improve algorithm or behaviour label May 7, 2023
@matt-frey matt-frey marked this pull request as ready for review May 16, 2023 15:47
@matt-frey
Copy link
Member Author

matt-frey commented May 16, 2023

We have now compared almost 23.5 billion merges. The parallel version returned the same results as the serial version.

Test 1

Total number of samples: 12000
Seeds: [45, 89, 351, 874]
MPI ranks: [16, 32, 64]
Number of parcels per sample: 1310720
Number of parcels per cell: 40
Number of fails: 0
Number of merges: 5802331176

Test 2 with 16, 32 and 64 MPI ranks; seed 875

#samples, #fails, #merges: 13200 0 6382621749

Test 3 with with 16, 32 and 64 MPI ranks; seed 43

#samples, #fails, #merges: 11800 0 5705727073

Test 4 with 72, 96 and 120 MPI ranks; seeds 45 89 351 874

#samples, #fails, #merges: 11500 0 5560559699

Copy link
Collaborator

@sjboeing sjboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick look. Happy for you to merge this once you have run a test case (like RT or moist bubble).

@matt-frey matt-frey merged commit 63f8a5c into 3d-mpi-model May 17, 2023
@matt-frey matt-frey deleted the use-request-based-rma branch May 17, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D Issues and pull requests related to the 3D version enhancement / optimisation Improve algorithm or behaviour MPI MPI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants