Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/a2c evaluation #195

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Fix/a2c evaluation #195

merged 3 commits into from
Jan 21, 2024

Conversation

belerico
Copy link
Member

Summary

This PR fixes #192, in particular:

  • we have add the evaluation file of the A2C agent cause a call to sheeprl/available_agents.py raises an erorr due the missing evaluation function of the A2C algorithm
  • we have also taken into consideration the fact that the evaluation file is manually set to evaluate in the sheeprl/available_agents.py file by saving in the sheeprl.utils.registry.evaluation_registry dictionary the name of the evaluation file where the evaluation funtion resides
  • no resolved config.yaml was being saved in the A2C algorithm

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 0e88153 into main Jan 21, 2024
10 checks passed
@belerico belerico deleted the fix/a2c-evaluation branch February 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error] Can't run "python sheeprl/available_agents.py", error message "KeyError: 'sheeprl.algos.a2c'"
2 participants