Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closingd: configurable closing fee negotiation step #3390

Merged
merged 2 commits into from
Apr 7, 2020
Merged

closingd: configurable closing fee negotiation step #3390

merged 2 commits into from
Apr 7, 2020

Commits on Apr 6, 2020

  1. build: use locale-independent sort for mocks 

    Use `LC_ALL=C sort` instead of `sort` so that mocks get sorted in
the same way on all developers' environments.

Re-record the result of `make update-mocks`.

Changelog-None
    @vasild
    vasild committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    7c81525 View commit details
    Browse the repository at this point in the history

  2. closingd: configurable closing fee negotiation step 

    When negotiating the transaction fee for closing a channel [1], we used
to always pick the middle of the range between our proposal and the
peer's proposal.

Introduce a new option `fee_negotiation_step` to the close command, so
the peer who initiates the close can choose his back off step.

Partially resolves ElementsProject#3270

[1] https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#closing-negotiation-closing_signed

Changelog-Added: New optional parameter to the `close` command to control the closing transaction fee negotiation back off step
    @vasild
    vasild committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    26c25ca View commit details
    Browse the repository at this point in the history