Reproducible null bolt11 propriety inside payment after the command pay #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent is nulled. In fact the result of test is reported bolow
```
_________________________________________________________________________________ test_bolt11_null_after_pay _________________________________________________________________________________
[gw6] linux -- Python 3.6.9 /usr/bin/python3
node_factory = <pyln.testing.utils.NodeFactory object at 0x7efcf4523240>, bitcoind = <pyln.testing.utils.BitcoinD object at 0x7efcf45f6f28>
def test_bolt11_null_after_pay(node_factory, bitcoind):
l1, l2 = node_factory.get_nodes(2)
amount_sat = 10 ** 6
# pay a generic bolt11 and test if the label bol11 is null
# inside the command listpays
# create l2->l1 channel.
l2.fundwallet(amount_sat * 5)
l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
l2.rpc.fundchannel(l1.info['id'], amount_sat * 3)
# Let the channel confirm.
bitcoind.generate_block(6)
sync_blockheight(bitcoind, [l1, l2])
invl1 = l1.rpc.invoice(Millisatoshi(amount_sat * 2 * 1000), 'j', 'j')['bolt11']
l2.rpc.pay(invl1)
pays = l2.rpc.listpays()["pays"]
> assert pays[0]["bolt11"] == invl1
E AssertionError: assert '(null)' == 'lnbcrt20m1p0...r0rawspstz0q8'
E - (null)
E + lnbcrt20m1p03kvqapp54g7memc5kaygdxc4lkshthjjf94mmrydrqqlws4rzz7shz57n45sdqzdgxqyjw5qcqp9sp58s7w77f8gyx7zygc99t7dmmnj89yjm8ku84np0n7xr86nsacu5us9qy9qsqy4te68majth9ulu7726mwx58apqe73eynkj69yn2fcs888jcu4e8xtu2r7l0gtpvv4vea460wvzt7c3vjzr0lgannmu3f09jpr0rawspstz0q8
tests/test_pay.py:248: AssertionError
```
vincenzopalazzo
changed the title
|
In addition, other to the test, I developed a solution to have the bolt11 value not null when the users use the command pay (json_paymod). I'm closing this PR to avoid confusion and to have a clear chronology of change. Moved on #3878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all.
During my work to understand (or try to understand) the code of c-lighting, I noted that after the command pay with the latest version of code inside the
release-0.9.0rc3branch the bolt11 propriety inside the json (also inside the DB) is NULL.This PRs reported the test that reproduces the problem, unfortunately, I don't find the problem that caused the NULL value.
P.S: I'm losing somethings inside the process? this behavior is normal and it is my idea is wrong?
I hope that this PR can help to find the problem quickly. Some print debug above
{ "pays": [ { "bolt11": "(null)", "status": "complete", "preimage": "4f731632e60c38e78a2e6defface0478d635f51889189bb0c941b758bec097ac", "amount_sent_msat": "1000msat" }, { "bolt11": "(null)", "status": "complete", "preimage": "46165a68960d5920ff16afd14051507315fc134466f1dd298a3bcb0715883be2", "amount_sent_msat": "10000msat" }, { "bolt11": "(null)", "status": "complete", "preimage": "31e68b396df25bb5e61c3422ff636d55573177bb10a138f9d1007937118fa8c3", "amount_sent_msat": "10000msat" }, { "bolt11": "(null)", "status": "complete", "preimage": "9a4f8576e0380394ab791b35e08793533b7d1d3303c383d91fda14a13978e7db", "amount_sent_msat": "1000msat" } ] }and this job report the assert error