channeld/channeld.c: Log and ignore repeated WIRE_CHANNEL_REESTABLISH. #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ElementsProject#3608 Changelog-Changed: protocol: Ignore (and log as "unusual") repeated `WIRE_CHANNEL_REESTABLISH` messages, to be compatible with buggy peer software that sometimes does this.
|
No idea how to test this tho. |
|
It honestly seems bonkers to me that the Lightning peer-wire protocol doesn't allow NAK'ing protocol messages in any way that allows the channel to remain open. How can we expect to achieve interoperability when implementations are utterly unable to say, "I disagree with (or did not understand) the message you just sent, so I will take no action, and you need not either"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3608
Changelog-Changed: protocol: Ignore (and log as "unusual") repeated
WIRE_CHANNEL_REESTABLISHmessages, to be compatible with buggy peer software that sometimes does this.