stop requiring channel and direction on sendonion since they're not used.

[fiatjaf]

Does this make sense?

Untested, wanted to make sure it made sense first.

[cdecker]

Changing just the requesting side breaks the receiving side. Please make the fields optional on the receiving side before removing them here.

[rustyrussell]

Changing just the requesting side breaks the receiving side. Please make the fields optional on the receiving side before removing them here.

This is wrong: patch doesn't quite do what the title says.

It actually does two things:

1. Fix sendonion to handle missing 'channel' and 'direction' properly.
2. Remove "channel" and "direction" from the call used by libplugin-pay.

We both saw the second one and thought JSON output fields were being removed. Too hasty!

[fiatjaf]

I think the sea of red tests was due to a variable name typo I had. Now locally there is only one test failing which seems unrelated or I couldn't understand it. Pushing temporarily anyway while I don't manage to find that out.

[cdecker]

The problematic changes were in the other PR, sorry for holding up the progress here.

[rustyrussell]

I squashed this into one commit, and tacked on a Changelog-Changed line.

Thanks!