Add plugin notification topic "block_added" #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiatjaf
force-pushed
the
notify_block_processed
branch
2 times, most recently
from
582d310
to
29f035d
Compare
Changelog-Added: Plugins: Added notification topic "block_processed".
fiatjaf
force-pushed
the
notify_block_processed
branch
from
29f035d
to
c8819a0
Compare
|
I think the failing tests are unrelated to this PR. |
vincenzopalazzo
approved these changes
Sep 11, 2022
There was a problem hiding this comment.
ACK c8819a0
Yes the test are failing regarding some timeout
|
I don't like this name, though, maybe |
As a notification, also |
|
|
|
+1 for |
|
what about |
|
ACK 357404b |
fiatjaf
changed the title
Comment on lines
+8
to
+19
| blocks_catched = [] | ||
|
|
||
|
|
||
| @plugin.subscribe("block_added") | ||
| def notify_block_added(plugin, block, **kwargs): | ||
| global blocks_catched | ||
| blocks_catched.append(block["height"]) | ||
|
|
||
|
|
||
| @plugin.method("blockscatched") | ||
| def return_moves(plugin): | ||
| return blocks_catched |
There was a problem hiding this comment.
I first read that as “cached”, but should that perhaps be “caught”?
There was a problem hiding this comment.
Sorry, I don't speak English. I will submit a PR renaming that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful for two completely unrelated plugins I'm working on recently, and it's a simple change that prevents the plugins from having to reimplement the block polling logic all by themselves every time.