Fix for #5572 and #5565 #5591
Merged
Fix for #5572 and #5565 #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gossip_store version byte was unaccounted for in the initial traversal of gossip_store_end. This lead to an offset and a bogus message length field. As a result, an early portion of the gossip_store could have been skipped, potentially leading to gossip propagation issues downstream. Fixes ElementsProject#5572 ElementsProject#5565 Changelog-fixed: proper gossip_store operation may resolve some previous gossip propagation issues
rustyrussell
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Ack 6af04d1
Changelog-Fixed should also note that it fixes a crash!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took more effort to debug than it appears, but I believe this is ultimately the source of the gossip_store offset error! Some of the previously reported node announcement propagation issues may have originated here as well. Accounting for the gossip_store's leading version byte is a simple fix.