List runes #6124
Merged
List runes #6124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
requested changes
Mar 25, 2023
There was a problem hiding this comment.
Hi Shahana!
Since this is your first core-lightning PR, I've gone through everything I can think of in my review! Mainly the commits need to be merged and resorted so the fix commits vanish, and all the commit subject lines should start with "commando: ", since they're all commando things.
In preparation for the listrunes command.
rustyrussell
force-pushed
the
list-runes
branch
from
7d050e7
to
cb1be1d
Compare
Changelog-Added: Plugins: `commando-listrunes` command to show issued runes.
Does not yet persist the blacklist. Changelog-Added: Plugins: `commando-blacklist` command to disable select runes.
Actually check them when we're going to use a rune.
rustyrussell
force-pushed
the
list-runes
branch
2 times, most recently
from
6fcc43b
to
b4acb3a
Compare
rustyrussell
approved these changes
Mar 31, 2023
|
Ack af30d35 |
rustyrussell
force-pushed
the
list-runes
branch
from
b4acb3a
to
af30d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.