cln-plugin: Change default log level filter back to INFO #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 60e1532 (released in crate 0.1.8), which switched the logging framework to tracing-subscriber, the default log level filter was (accidentally) set to ERROR and above, instead of INFO and above. Change this back to INFO as it was before. It can still be overridden with CLN_PLUGIN_LOG. Follows the example in https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#method.from_env Closes ElementsProject#7658. Changelog-Fixed: cln-plugin: Change default log level filter back to INFO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cln-plugin: Change default log level filter back to INFO
Description
In commit 60e1532 (released in crate 0.1.8), which switched the logging framework to tracing-subscriber, the default log level filter was (accidentally) set to ERROR and above, instead of INFO and above.
Change this back to INFO as it was before. It can still be overridden with environment variable
CLN_PLUGIN_LOG.Follows the example in https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#method.from_env
Related Issues
Changes Made
Changelog-Fixed: cln-plugin: Change default log level filter back to INFO
Checklist
Ensure the following tasks are completed before submitting the PR:
TODOshave been addressed or removed.