Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model load observation API #3142

Closed
wants to merge 1 commit into from

Conversation

embeddedt
Copy link
Contributor

@embeddedt embeddedt commented Jun 24, 2023

The following PR implements a standardized API mods such as Continuity can use to have low-level control over what model instances are loaded and baked within the ModelLoader. One benefit of standardizing this system is that it will allow optimization mods such as my own to safely implement dynamic model loading/unloading at runtime without running into compatibility problems when mods that inject into ModelLoader directly. It also makes it easy for modders to replace models without needing to learn exactly how the model loader works.

EDIT: Will run checkstyle after other concerns are addressed.

@Technici4n Technici4n self-assigned this Jun 24, 2023
@Technici4n
Copy link
Member

This now lives inside of #3145.

@Technici4n Technici4n closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants