Add event for preventing particle tinting for colored blocks #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an event, `ParticleRenderEvents.ALLOW_BLOCK_DUST_TINT`, that checks if a block dust particle of a specific block can be tinted. - Bumps Fabric Loader requirement of fabric-particles-v1 to latest to disable Loader's mixin compatibility mode that ignores slices for certain At annotations.
Juuxel
added
enhancement
Technici4n
approved these changes
Jun 26, 2023
haykam821
approved these changes
Jun 28, 2023
modmuss50
approved these changes
Jun 28, 2023
modmuss50
added
last call
modmuss50
pushed a commit
that referenced
this pull request
Jul 3, 2023
- Adds an event, `ParticleRenderEvents.ALLOW_BLOCK_DUST_TINT`, that checks if a block dust particle of a specific block can be tinted. - Bumps Fabric Loader requirement of fabric-particles-v1 to latest to disable Loader's mixin compatibility mode that ignores slices for certain At annotations. Signed-off-by: modmuss50 <modmuss50@gmail.com>
modmuss50
pushed a commit
to modmuss50/fabric
that referenced
this pull request
Nov 22, 2023
…C#3146) - Adds an event, `ParticleRenderEvents.ALLOW_BLOCK_DUST_TINT`, that checks if a block dust particle of a specific block can be tinted. - Bumps Fabric Loader requirement of fabric-particles-v1 to latest to disable Loader's mixin compatibility mode that ignores slices for certain At annotations. Signed-off-by: modmuss50 <modmuss50@gmail.com> (cherry picked from commit 86d4888)
modmuss50
added a commit
that referenced
this pull request
Nov 26, 2023
…3433) - Adds an event, `ParticleRenderEvents.ALLOW_BLOCK_DUST_TINT`, that checks if a block dust particle of a specific block can be tinted. - Bumps Fabric Loader requirement of fabric-particles-v1 to latest to disable Loader's mixin compatibility mode that ignores slices for certain At annotations. Signed-off-by: modmuss50 <modmuss50@gmail.com> (cherry picked from commit 86d4888) Co-authored-by: Juuz <6596629+juuxel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event,
ParticleRenderEvents.ALLOW_BLOCK_DUST_TINT, that checks if a block dust particle of a specific block can be tinted.The API is useful for partially coloured blocks that use a coloured texture in their models but a non-coloured particle texture, like vanilla grass blocks or various thin tree logs with leaves from biome mods.
Also bumps the Fabric Loader requirement of fabric-particles-v1 to latest to disable Loader's mixin compatibility mode that ignores slices for certain
@Atannotations.The area of vanilla code seems to be very stable - this change should be backportable with only test mod changes all the way to 1.18.2 and maybe even further.