Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to control creative inventory screen #3814

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented May 30, 2024

Closes #3813

@modmuss50 modmuss50 added the enhancement New feature or request label May 30, 2024
@modmuss50 modmuss50 marked this pull request as ready for review May 31, 2024 12:51
@modmuss50 modmuss50 requested a review from a team May 31, 2024 12:51
@modmuss50 modmuss50 added the last call If you care, make yourself heard right away! label Jun 2, 2024
Copy link
Contributor

@haykam821 haykam821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parts of the Javadoc could be clarified.

modmuss50 and others added 2 commits June 4, 2024 14:58
Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>
…pi/client/itemgroup/v1/FabricCreativeInventoryScreen.java

Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Jun 7, 2024
@modmuss50 modmuss50 merged commit 00ab0a6 into FabricMC:1.21 Jun 8, 2024
4 checks passed
modmuss50 added a commit that referenced this pull request Jun 8, 2024
* Add API to control creative inventory screen

* Rename methods

* Apply suggestions from code review

Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>

* Update fabric-item-group-api-v1/src/client/java/net/fabricmc/fabric/api/client/itemgroup/v1/FabricCreativeInventoryScreen.java

Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>

---------

Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>

(cherry picked from commit 00ab0a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request last call If you care, make yourself heard right away! merge me please Pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants