Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handled screen not calling super.mouseReleased or super.mouseDragged #4010

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

modmuss50
Copy link
Member

Im not super keen on this fix as it feels like a recipe for something sutble to break. Id be intrested to know how others feel about this.

This fixes an issue where mouseReleased or mouseDragged would not be called for buttons added to HandledScreens.

@modmuss50 modmuss50 added bug Something isn't working priority:low Low priority PRs that don't immediately need to be resolved labels Aug 7, 2024
@modmuss50 modmuss50 requested a review from a team August 7, 2024 19:06
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Aug 11, 2024
@modmuss50 modmuss50 merged commit 8b68f1c into FabricMC:1.21.1 Aug 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge me please Pull requests that are ready to merge priority:low Low priority PRs that don't immediately need to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant