Add fuel registry events #4038
Merged
Add fuel registry events #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
suggested changes
Aug 19, 2024
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...egistries-v0/src/main/java/net/fabricmc/fabric/mixin/content/registry/FuelRegistryMixin.java
Outdated
Show resolved
Hide resolved
modmuss50
added
port
modmuss50
reviewed
Aug 19, 2024
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...tries-v0/src/testmod/java/net/fabricmc/fabric/test/content/registry/ContentRegistryTest.java
Outdated
Show resolved
Hide resolved
Patbox
reviewed
Aug 19, 2024
...egistries-v0/src/main/java/net/fabricmc/fabric/mixin/content/registry/FuelRegistryMixin.java
Outdated
Show resolved
Hide resolved
haykam821
commented
Aug 20, 2024
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...-registries-v0/src/main/java/net/fabricmc/fabric/api/registry/FabricFuelRegistryBuilder.java
Outdated
Show resolved
Hide resolved
...egistries-v0/src/main/java/net/fabricmc/fabric/mixin/content/registry/FuelRegistryMixin.java
Outdated
Show resolved
Hide resolved
|
@haykam821 are you still planning on looking at this? No rush but it would be nice to get it in. Let me know if you want me to take over. |
|
I have updated this PR with the changes requested, there was only a little bit left. |
modmuss50
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft pull request is a first pass at a successor for Fabric API's
FuelRegistry(which may be reintroduced as a deprecated class as well). More details will follow.