Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial port to 24w35a #4062

Merged
merged 16 commits into from
Aug 29, 2024
Merged

Initial port to 24w35a #4062

merged 16 commits into from
Aug 29, 2024

Conversation

apple502j
Copy link
Contributor

@apple502j apple502j commented Aug 29, 2024 •
edited
Loading

Breaking Change

  • Object Builder: removed deprecated FabricBlockSettings
  • Removed no-arg overload of FabricEntityType.Builder#build. Use the vanilla one, which requires RegistryKey, instead. Passing null causes a NPE.

@apple502j apple502j added the port Porting existing code to a different version label Aug 29, 2024
@apple502j apple502j marked this pull request as ready for review August 29, 2024 16:21
modmuss50
modmuss50 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, many thanks for this.

@modmuss50 modmuss50 merged commit 2cd4845 into FabricMC:1.21.2 Aug 29, 2024
4 checks passed
@FabricMC FabricMC deleted a comment from dznrm Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
port Porting existing code to a different version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apple502j @modmuss50