Add component system #4115
Draft
Add component system #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. Unfortunately I dont think this is something that fits within the scope of what we want in Fabric API. We already have the events, so you could always build something like this ontop of those in your own mods if needed. This seems too complicated for very little added benefit for most people. Im more than happy to discuss this further with you. In the future I would suggest creating an issue or message in the discord to get some inital feedback on an idea before spending time developing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of an entity component system built on top of the data attachments API and existing events. More events will need to be added for the currently registered
AttachmentTargets, but I wanted to get opinions on API structure first.