Remove math.div warnings when compiling components #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
components
This commit introduces a temporary helper library to avoid newer dart-sass versions printing warnings when compiling Origami. The library contains a `div` function which is defined twice, once in `index.scss` and again in `index.import.scss` When compiling using dart-sass, the `index.import.scss` file will be used, which implements the `div` function with the new `math.div` if supported and with `/` if not supported. When compiling using libsass or rubysass or node-sass, the `index.scss` file will be used, which implements the `div` function using the `/` operator (which is deprecated in dartsass) As well as a `div` function, the library also re-exports all the functions from `mathsass` but re-implements the ones which used the `/` operator, such as `pow` and `sqrt`.
|
@Financial-Times/origami-core This is now ready for a review :-D |
notlee
reviewed
Nov 3, 2021
| <img width="500" height="500" src="https://avatars3.githubusercontent.com/u/9341289?v=3&s=500" alt="Awesome"> | ||
| </div> | ||
|
|
||
| # Media Queries with superpowers [](https://travis-ci.org/sass-mq/sass-mq) |
There was a problem hiding this comment.
would be great to add a note here as to why we're forking it, as in the math library :)
There was a problem hiding this comment.
done in 71a92c0 (#385)
notlee
reviewed
Nov 3, 2021
Comment on lines
+32
to
+34
| // math.div was added in version 1.33.0 | ||
| // import-only files were added in version 1.23.0 | ||
| // meta.module-functions was added in version 1.23.0 |
notlee
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a temporary helper library named
@financial-times/mathto avoid newer dart-sass versions printing warnings when compiling Origami.The library contains a
divfunction which is defined twice, once inindex.scssand again inindex.import.scssWhen compiling using dart-sass, the
index.import.scssfile will be used, which implements thedivfunction with the newmath.divif supported and with/if not supported.When compiling using lib-sass or ruby-sass, the
index.scssfile will be used, which implements thedivfunction using the/operator (which is deprecated in dart-sass)As well as a
divfunction, the library also re-exports all the functions frommathsassbut re-implements the ones which used the/operator, such aspowandsqrt.I've also added an internal fork of
sass-mqwhich makes use of@financial-times/mathto remove the last remaining sass warnings which happen