Remove eigen and eigvals adjoints for Symmetric/Hermitian #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accept |
|
Okay, the test suite passed without the rule (except on Julia 1.3, which seems to have a CUDA issue), and the tests have now been removed, so this is ready for review. |
oxinabox
reviewed
Jan 9, 2021
oxinabox
approved these changes
Jan 9, 2021
|
Thanks, this looks good! |
|
It'd be nice to keep tests if it's not too much, so we can test changes in Zygote more thoroughly as well |
This reverts commit fcf5559.
|
Okay, I added the tests back. This should now be ready to merge. |
|
The failure on 1.3 is curious but not related to this PR, so wouldn't block it. Thanks! |
DhairyaLGandhi
approved these changes
Jan 9, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaDiff/ChainRules.jl#323 added rrules for
eigenandeigvalsfor Symmetric/Hermitian matrices. This PR removes those rules from Zygote. Once the old tests pass, I'll remove them, since the rrules are more thoroughly tested.Depends on JuliaRegistries/General#27508 is merged.