Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreHttp] Add strncasecmp implementation #106

Merged
merged 34 commits into from
Jul 10, 2021

Conversation

gshvang
Copy link
Contributor

@gshvang gshvang commented Jul 7, 2021

This PR contains the implementation for strncasecmp function as strncasecmp is not a standard C function and is not compatible across different platforms. This fix is needed as a result of change contributed by external PR to have case insensitive matching of field name in the header as header field consists of a case-insensitive field name (RFC 7230, section 3.2).

source/core_http_client.c Outdated Show resolved Hide resolved
source/core_http_client.c Outdated Show resolved Hide resolved
source/core_http_client.c Outdated Show resolved Hide resolved
source/core_http_client.c Outdated Show resolved Hide resolved
source/core_http_client.c Outdated Show resolved Hide resolved
source/core_http_client.c Outdated Show resolved Hide resolved
source/core_http_client.c Outdated Show resolved Hide resolved
yourslab
yourslab previously approved these changes Jul 9, 2021
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

source/core_http_client.c Show resolved Hide resolved
gshvang and others added 2 commits July 9, 2021 11:55
Co-authored-by: Muneeb Ahmed <54290492+muneebahmed10@users.noreply.github.com>
@gkwicker gkwicker dismissed their stale review July 9, 2021 23:44

comments have been addressed

archigup
archigup previously approved these changes Jul 9, 2021
source/core_http_client.c Outdated Show resolved Hide resolved
@gshvang gshvang merged commit 870b352 into FreeRTOS:main Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants