Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSharp.Analyzers.SDK and related deps #83

Merged
merged 5 commits into from
May 17, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented May 16, 2024

The existing version didn't seem to work for me in the latest Ionide, so - an attempt to update it to match the latest Ionide.Analyzers (a local debug build seems to work for me in Ionide 7.20 at least)

@nojaf
Copy link
Contributor

nojaf commented May 16, 2024

The existing version didn't seem to work for me in the latest Ionide

Thanks, although I would like to point out that is literally hasn't been 24 hours since this mismatch 😅.

@nojaf
Copy link
Contributor

nojaf commented May 16, 2024

Could you bump the SDK to 8.0.300 and the tools to their latest stable version?

@Numpsy
Copy link
Contributor Author

Numpsy commented May 16, 2024

The existing version didn't seem to work for me in the latest Ionide

Thanks, although I would like to point out that is literally hasn't been 24 hours since this mismatch 😅.

Yeah, just happened to cooincide with me trying to update some things at work :-)

@Numpsy
Copy link
Contributor Author

Numpsy commented May 16, 2024

Is it worth updating the github actions at the same time? (there are some build warnings about deprecated versions)
image

@Numpsy Numpsy marked this pull request as ready for review May 16, 2024 14:11
@nojaf
Copy link
Contributor

nojaf commented May 16, 2024

Yep, that sounds good.

nojaf
nojaf previously approved these changes May 17, 2024
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nojaf nojaf merged commit 360e3d3 into G-Research:main May 17, 2024
1 check passed
@nojaf
Copy link
Contributor

nojaf commented May 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants