Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libnuma in cryptol-remote-api Dockerfile #1656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weaversa
Copy link
Collaborator

I was experimenting w/ shrinking the image and noticed that apt autoremove removes the libnuma .so file due to the dev version being installed. Here I change the Dockerfile to use the non-dev version of libnuma.

Using non-dev version of libnuma
@RyanGlScott
Copy link
Contributor

Thanks for the patch!

Could you explain a bit further how you're pruning unused dependencies? I tried running apt autoremove as root in a cryptol-remote-api container, but that doesn't do anything when I try it:

$ docker run -u root --rm -it --entrypoint /bin/bash ghcr.io/galoisinc/cryptol-remote-api:3.1.0
root@f496157db665:/home/cryptol# apt autoremove
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

(I can certainly believe that we could remove some dependencies, however, so I'm open to your ideas on how we can do better here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants