Update cython #51
Merged
Update cython #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cython, const's can't be used for local variables, only for function interfaces.
The estimator function and the normalization of the variogram are now being calculated in a separate function. Function pointers are used for the flexibility of choosing different estimator functions.
The function pointers in cython seem to be a bit limited, therefore I wrote 2 separate functions choosing the estimator func. and the norm. func.
In the cython code, merged the 1d-, 2d-, and 3d-versions of the structured variogram estimators into the 3d version, with a tiny little bit of preparation code in the python wrappers. Switched off the OpenMP loop for the moment, as it always results in errors for the 1d case and sometimes causes problems for higher dimensions. Super strange!
I learnt a lot about OpenMP. It seems very difficult, to adequately parallelise the structured variogram estimator in Cython. Its OpenMP support is simply to good enough. I parallelised the inner loop. It's better than nothing. The function could be implemented in pure C, C++ or maybe Rust.
LSchueler
added
enhancement
MuellerSeb
reviewed
Dec 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a lot of changes to the Cython implementation of the variogram estimators. The code is a lot cleaner now and the two major changes are