fix: multiple image upload issue using native image picker and generic improvements for upload #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c improvements for upload
SDK Size
|
santhoshvai
reviewed
Aug 28, 2024
santhoshvai
reviewed
Aug 28, 2024
santhoshvai
reviewed
Aug 28, 2024
Comment on lines
407
to
408
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [selectedFilesLength]); |
santhoshvai
reviewed
Aug 28, 2024
isekovanic
approved these changes
Aug 28, 2024
isekovanic
reviewed
Aug 28, 2024
| await uploadFilesHandler(); | ||
| } else { | ||
| /** User de-selected a video in bottom sheet attachment picker */ | ||
| removeFilesHandler(); |
There was a problem hiding this comment.
This also covers the case where selectedFilesLength === fileUploadsLength, is this the desired behaviour ? Just curious about this, not a remark
oliverlaz
reviewed
Aug 29, 2024
|
🎉 This PR is included in version 5.36.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal of the PR is to primarily solve the multiple image upload issue on the new architecture but this also applies to the current v5 branch as the improvements here make sense and are not architectural dependant.
There are a few improvements in the
useEffectof theMessageInputas well that is supposed to target only the media library(attachment picker) but don't make sense for the native image pickers, so proper checks are added around the same and improves the upload process for normal use-cases.The PR also solves the issue of clicked images not respecting the file size config check.
☑️ Checklist
developbranch