264 improve normality test #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normality tests accepts now numpy ndarrays. Added test for ndarray. Added check for empty np.ndarray.
Added checks and tests for non-numeric data.
Created new exception class, checks and tests for maximum sample size. Max set to 5000 samples.
nmaarnio
reviewed
Dec 29, 2023
Added missing data handling, and tests for it.
Changed dataframe column validation for consistency.
Closed
6 tasks
nmaarnio
requested changes
Jan 2, 2024
Comment on lines
62
to
63
| data: Dataframe or numpy array containing the input data. | ||
| columns: Optional Columns to be used for testing. |
There was a problem hiding this comment.
Suggested change
| data: Dataframe or numpy array containing the input data. | |
| columns: Optional Columns to be used for testing. | |
| data: Dataframe or Numpy array containing the input data. | |
| columns: Optional columns to be used for testing. |
- Fixed typos. - Clarified return types, and improved docstring. - Removed check and test for numeric data for Numpy array.
Better formatting for autogenerated docs.
nmaarnio
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made improvements for normality test as requested in issue#264 .