-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed QWidget -> QMainWindow to allow the application menu bar. QgsInterface returns a new QToolBar when addToolBar is called #14
Conversation
I'm quite new to github. I wanted to create two PR, but my two commits appear in one PR. Also I detected that when a plugin calls the addToolBar function from iface, None was returned. But if this function is called a new toolbar has to be returned to the plugin abling it to add actions. |
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 53.20% 52.79% -0.42%
==========================================
Files 6 6
Lines 421 430 +9
==========================================
+ Hits 224 227 +3
- Misses 197 203 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution, it is much appreciated!!
Don't worry about PRs, this is fine if you just modify the title of the PR to address both changes :)
I added some minor comments but other than that, can you just install pre-commit with:
pre-commit install
and that should fix all the code style issues automatically during the next commit. I should add pre-commit instructions to the README.md as well.
Co-authored-by: Joonalai <33314057+Joonalai@users.noreply.github.com>
Co-authored-by: Joonalai <33314057+Joonalai@users.noreply.github.com>
Hello @Joonalai, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Just one more tiny detail :) And I forgot to mention: code style fails, since you did not edit those other files. You have to run pre-commit manually now. Use pre-commit run --all-files
in your console.
Co-authored-by: Joonalai <33314057+Joonalai@users.noreply.github.com>
Thank you for your hints. |
Proposal to solve issue #13