Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty configuration path in tests #2

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Use empty configuration path in tests #2

merged 2 commits into from
Oct 6, 2021

Conversation

LKajan
Copy link
Contributor

@LKajan LKajan commented Oct 6, 2021

  • Use empty config path to make sure there are no existing profiles etc. interfering the tests.
  • Close QgsApplication after tests are run.

Both are inspired by
https://github.com/qgis/QGIS/blob/498c52365d380f5a664dbb71961fd149fc1ad8c1/python/testing/__init__.py#L460

Joonalai
Joonalai approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@Joonalai Joonalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just few minor details.

src/pytest_qgis/pytest_qgis.py Outdated Show resolved Hide resolved
src/pytest_qgis/pytest_qgis.py Outdated Show resolved Hide resolved
@Joonalai Joonalai merged commit 5361d8d into main Oct 6, 2021
@github-actions github-actions bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joonalai Joonalai Joonalai approved these changes

@mvaaltola mvaaltola Awaiting requested review from mvaaltola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LKajan @Joonalai