Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QToolBar in iface.addToolBar #23

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Support QToolBar in iface.addToolBar #23

merged 3 commits into from
Jun 17, 2022

Conversation

Joonalai
Copy link
Contributor

@Joonalai Joonalai commented May 20, 2022

This PR:

  • Adds possibility to use QToolBar as an argument in iface.addToolBar method
  • Fixes pre-commit environment

Fixes #19.

@Joonalai Joonalai changed the title 19 fix add tool bar Support QToolBar in iface.addToolBar May 20, 2022
@Joonalai
Copy link
Contributor Author

The test fail with latest QGIS because of this line (which makes it possible to rearrange layers) https://github.com/GispoCoding/pytest-qgis/blob/main/src/pytest_qgis/pytest_qgis.py#L342

@Joonalai Joonalai force-pushed the 19_fix-addToolBar branch 2 times, most recently from c235068 to 5f751f6 Compare June 17, 2022 10:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #23 (5f751f6) into main (7f17044) will increase coverage by 0.39%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   54.09%   54.48%   +0.39%     
==========================================
  Files           7        7              
  Lines         464      468       +4     
==========================================
+ Hits          251      255       +4     
  Misses        213      213              
Flag Coverage Δ
pytest 54.48% <77.77%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytest_qgis/qgis_interface.py 44.00% <77.77%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f17044...5f751f6. Read the comment docs.

@Joonalai Joonalai merged commit 70a3000 into main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use addToolBar with qgis_iface
2 participants