Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use session scope in qgis_bot fixture #46

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Joonalai
Copy link
Contributor

@Joonalai Joonalai commented Nov 21, 2023

This PR:

  • Turns qgis_bot into session scoped fixture since its only requirement is session scoped as well and it has no reason to have any other scope
  • Deprecates module_qgis_bot since it has no purpose anymore

@Joonalai Joonalai changed the title refactor: use session scope in qgis_bot fixture Use session scope in qgis_bot fixture Nov 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (631d92b) 56.35% compared to head (b856341) 56.44%.

Files Patch % Lines
src/pytest_qgis/pytest_qgis.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   56.35%   56.44%   +0.08%     
==========================================
  Files           7        7              
  Lines         488      489       +1     
==========================================
+ Hits          275      276       +1     
  Misses        213      213              
Flag Coverage Δ
pytest 56.44% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LKajan LKajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add reasoning why this change is done to the commit body and to the PR description.

since its only requirement is session scoped as well and it has no reason to have any other scope
@LKajan LKajan merged commit 1895072 into GispoCoding:main Nov 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants