Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] tarPath is not relative path, but it should be #675

Closed
kwladyka opened this issue May 22, 2019 · 4 comments
Closed

[bug] tarPath is not relative path, but it should be #675

kwladyka opened this issue May 22, 2019 · 4 comments
Labels
area/file-extraction kind/bug Something isn't working priority/p3 agreed that this would be good to have, but no one is available at the moment. work-around-available

Comments

@kwladyka
Copy link

Actual behavior
docker run --rm -w /workspace -v (pwd):/workspace gcr.io/kaniko-project/executor --tarPath=image.tar --context=auth-provider --no-push

image.tar is saved who know where. If I change it to --tarPath=/workspace/image.tar then it works.

Expected behavior
Save it in right relative path. In case about in /workspace/image.tar.

Additional Information
I need it to produce tar in relative path in Concourse (cicd). It is random path so it not constant.
@kwladyka kwladyka changed the title tarPath is not relative path, but it should be [bug] tarPath is not relative path, but it should be May 22, 2019
@kwladyka kwladyka mentioned this issue May 22, 2019
Closed
@jukie
Copy link

jukie commented May 30, 2019 •
edited
Loading

Relative path to what? In this case image.tar is being saved at /image.tar because you aren't providing a path to save to, so the root /... is assumed.

If you need to save it outside of the /workspace directory, would adding another volume mount be an option? The path being used for --tarPath is from inside the container so you should always have the ability to control what's used. I don't understand where the randomness is coming from.

@kwladyka
Copy link
Author

It should be saved in /workspace/image.tar because I am running command from /workspace and I use relative path image.tar.

@kwladyka
Copy link
Author

In practice I run it from /tmp/fooX/barY in Concourse (cicd) and I need to save it in artefact directory /tmp/fooX/barY/artefact by Concourse instead docker run.

But example with docker run is simple to recreate and easy to understand the issue.

@huguesalary huguesalary mentioned this issue Aug 7, 2019
Closed
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 9, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
f8427fb 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#31 GoogleContainerTools#675
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 9, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
86501d8 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#31 GoogleContainerTools#675
@huguesalary huguesalary mentioned this issue Aug 9, 2019
Merged
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 9, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
4a4b0ff 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#31 GoogleContainerTools#675
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 9, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
2818b3e 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#731 GoogleContainerTools#675
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 9, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
ad587f6 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#731 GoogleContainerTools#675
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 19, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
c7104e7 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#731 GoogleContainerTools#675
huguesalary added a commit to huguesalary/kaniko that referenced this issue Aug 27, 2019
@huguesalary
Resolve relative paths to absolute paths in command line arguments
4327e9b 
The executor accepts a few arguments dockerfile, context, cache-dir and
digest-file that all represent paths. This commits allows those paths to
be relative to the working directory of the executor.

Fixes GoogleContainerTools#732 GoogleContainerTools#731 GoogleContainerTools#675
@donmccasland donmccasland added area/file-extraction priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Sep 20, 2019
@tejal29 tejal29 added the kind/bug Something isn't working label Sep 27, 2019
@tejal29
Copy link
Member

tejal29 commented Oct 2, 2019

this should be fixed by #736

@tejal29 tejal29 closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/file-extraction kind/bug Something isn't working priority/p3 agreed that this would be good to have, but no one is available at the moment. work-around-available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@donmccasland @tejal29 @kwladyka @jukie