Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-arch image via Bazel #1452

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

mattmoor
Copy link
Collaborator

@mattmoor mattmoor commented Oct 8, 2020

Description

This starts to add multi-arch container images built via Bazel, turned into "manifest lists" in the Docker daemon, and published.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

The executor:bazel image now supports both amd64 and arm64.

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Oct 8, 2020
@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 8, 2020

I'm staging this to test the Travis integration, but I need to make the cloudbuild.yaml changes non-invasive (right now they are breaking, and should not be merged)

cc @tejal29

@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 8, 2020

Travis seems to have not gotten notified, or is otherwise upset with me... 🤔

@mattmoor mattmoor force-pushed the multi-arch branch 2 times, most recently from c9cb67f to de77939 Compare October 8, 2020 18:10
@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 8, 2020

Alright, commenting the travis changes seems to have unwedged it. I "love" silent failures 🙃

@mattmoor mattmoor force-pushed the multi-arch branch 2 times, most recently from 1a38e8e to 582844d Compare October 8, 2020 18:13
@tejal29
Copy link
Member

tejal29 commented Oct 8, 2020

Looks like we need to switch to paid tier for travis.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 8, 2020

Alright, my stripped down Travis build passed, so I uncommented everything here: https://travis-ci.org/github/GoogleContainerTools/kaniko/builds/734073723

This should be RFAL, please look carefully at the deploy/cloudbuild_release.yaml as I did not test that due to hard-coded project and use of tags.

@mattmoor mattmoor changed the title [WIP] Add multi-arch image via Bazel Add multi-arch image via Bazel Oct 8, 2020
@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 8, 2020

Everything is green! 🤩

Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some nits on code organization.

cmd/executor/BUILD Outdated Show resolved Hide resolved
cmd/executor/testdata/Dockerfile.trivial Outdated Show resolved Hide resolved
cmd/executor/BUILD Outdated Show resolved Hide resolved
@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 8, 2020

Alright, looks like the previous failure was a flake, so this should be RFAL.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Oct 9, 2020

@tejal29 LMK if these needs anything else!

@tejal29 tejal29 merged commit a310cc6 into GoogleContainerTools:master Oct 9, 2020
@tejal29
Copy link
Member

tejal29 commented Oct 9, 2020

I will share the results of GCB tirgger with you.

tejal29 added a commit to tejal29/kaniko that referenced this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants